Re: [patch] sched: align rq to cacheline boundary

From: Siddha, Suresh B
Date: Tue Apr 10 2007 - 19:48:48 EST


On Tue, Apr 10, 2007 at 08:36:56AM +0200, Ingo Molnar wrote:
> the runqueue is really supposed to be cacheline-isolated at _both_ ends
> - at its beginning and at its end as well.

Then either we need to define the first element in the struct as
cacheline aligned or move into section where all the elements are
cacheline aligned. My current patch will not align it at the end.

> > Remember also that the linesize on VSMP is 4k.
>
> that sucks ...
>
> maybe, to mitigate some of the costs, do a special PER_CPU_CACHE_ALIGNED
> area that collects per-cpu fields that also have significant cross-CPU
> use and need cacheline isolation? Such cacheline-aligned variables, if
> collected separately, would pack up more tightly and would cause only
> half of the wasted space.

I will post a patch(once Jermey's page align percpu patch goes in to -mm)

thanks,
suresh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/