Re: [PATCH] Re: kernel oops with badly formatted module option

[Rusty Russell]

On Sat, 2007-04-07 at 19:47 -0700, Randy Dunlap wrote:
> On Sat, 07 Apr 2007 19:21:01 -0500 Larry Finger wrote:
> 
> > With the following line in /etc/modprobe.conf.local:
> > 
> > options bcm43xx fwpostfix = ".fw3" locale=8
> > 
> > the kernel oops below is generated. I realize that the line should have no whitespace around the 
> > "=", but I do not feel that an oops is the best way to report the syntax error. Could there be a more gentle failure?
> 
> 
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> Catch malformed kernel parameter usage of "param = value".
> Spaces are not supported, but don't cause a kernel fault on
> such usage, just report an error.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Thanks Randy,

	I even read your patch before I wrote my own, for a change!

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/