Re: [PATCH 4/5] Char: cyclades, remove volatiles

[Jiri Slaby]

Andrew Morton napsal(a):
> On Wed,  4 Apr 2007 23:45:38 +0200 (CEST) Jiri Slaby <jirislaby@xxxxxxxxx> wrote:
> 
>> cyclades, remove volatiles
> 
> The other changes seem uncontroversial, but this one has the potential
> to change runtime behaviour.  And cyclades.c is a driver which some people
> actually use ;)

Well, don't you know anybody with Z card, please?

But all volatiles were
- used locally (loop variables, nonptr count read once from HW), so that nothing
has a chance to change them in the memory.
- accessed by readX/writeX (pointers to mapped HW) and that should be OK

> Have these changes been runtime-tested?

Yes this time :), I have at least PCI Y cyclades card within reach to test.

thanks,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/