Re: [PATCH] Deprecate SA_xxx interrupt flags -V2

[Ingo Molnar]

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> Yeah.  I tried something like this and code broke.  For example,
> arch/mips/sni/irq.c has
> 
> struct irqaction sni_isa_irq = {
> 	.handler = sni_isa_irq_handler,
> 	.name = "ISA",
> 	.flags = SA_SHIRQ
> };
> 
> there are presumably only a few such stragglers left in the tree but 
> there are probably more instances out-of-tree.

i quick grep suggests that this seems to be the only one left with a 
similar pattern:

 dione:~/linux/ find . -name '*.[ch]' | xargs grep -E '\..*=.*\<SA_' | 
                grep -vE '\;|\(|=='

 ./arch/mips/sni/irq.c:  .flags = SA_SHIRQ

so the patch is fine to me:

 Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/