Re: [PATCH] USB gadget rndis: fix bug skb_push function may returnan unaligned pointer bug

From: Wu, Bryan
Date: Thu Apr 05 2007 - 22:23:45 EST


On Thu, 2007-04-05 at 14:29 -0700, David Brownell wrote:
> On Tuesday 03 April 2007 11:28 pm, Wu, Bryan wrote:
> > USB gadget rndis: skb_push function may return a pointer which is not
> > aligned as required by struct rndis_packet_msg_type.
>
> Can you instead try to update the declaration of that struct
> so that it's "__attribute__((packed))"? That's less invasive,
> and will address similar issues elsewhere ...
>
> - Dave

OK, Jie and Roy will try to use this __attribute__ method and test it on
blackfin platform. Sorry for missing their "Signed-off-by". I will
resend a patch later for review.

Thanks
-Bryan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/