Re: [PATCH 12/14] get_unmapped_area handles MAP_FIXED in /dev/mem (nommu)

From: David Howells
Date: Wed Apr 04 2007 - 06:31:45 EST


Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> + if (flags & MAP_FIXED)
> + if ((addr >> PAGE_SHIFT) != pgoff)
> + return (unsigned long) -EINVAL;

Again... in NOMMU-mode there is no MAP_FIXED - it's rejected before we get
this far.

> - return pgoff;
> + return pgoff << PAGE_SHIFT;

That, however, does appear to be a genuine bugfix.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/