Re: [PATCH 6/13] maps: Move the page walker code to lib/

[Nick Piggin]

Matt Mackall wrote:
> On Wed, Apr 04, 2007 at 01:51:37PM +1000, Nick Piggin wrote:
>
> > Matt Mackall wrote:
> >
> > > Move the page walker code to lib/
> > >
> > > This lets it get shared outside of proc/ and linked in only when
> > > needed.
> >
> > I think it would be better in mm/.
>
>
> I originally was looking at putting it in mm/memory.c and possibly

Just put it in its own file in mm/ rather than its own file in lib.
lib should be for almost-standalone stuff, IMO (ie. only using basic
kernel functionality).

Yes, I think ioremap.c should be in mm/ as well.

> converting some users there. But I decided it ought to be
> conditionally linked until it had some core users and I wasn't quite
> ready to tackle the tricky mm/ bits.

Apart from these users outside mm/, I don't see much point in converting
things over. The page table walking API we have now is neat and simple.
It takes a few lines of code, but is it a big problem?

--
SUSE Labs, Novell Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/