Re: [PATCH] make csum_partial obj-y

[Randy Dunlap]

Andi Kleen wrote:
> Randy Dunlap <randy.dunlap@xxxxxxxxxx> writes:
>
> > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> >
> > Fixes kernel bugzilla #8242:
> >
> > Move csum_partial() from lib-y to obj-$(CONFIG_CSUM_PARTIAL)
> > so that modules can use it.
> >
> > CONFIG_BLK_DEV_MD (md/raid driver) needs csum_partial(),
> > even when CONFIG_NET=n and BLK_DEV_MD=m, so build it as an
> > object to force it being built and available.
> >
> > REISERFS with XATTR=y also needs csum_partial(), so that
> > is enforced here.
>
> They are all broken because csum_partial gives different values
> on different architectures.   You're just extending that to
> possibly more subsystems.

So the ones that can be localized (BLK_DEV_MD and REISERFS)
should have their own versions?

How does the networking code work across multiple architectures?

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/