Re: [patch 2.6.21-rc5-git 1/2] fix hotplug for legacy platform drivers

From: David Brownell
Date: Mon Apr 02 2007 - 16:17:41 EST


On Monday 02 April 2007 1:10 pm, Dmitry Torokhov wrote:
> On 3/31/07, David Brownell <david-b@xxxxxxxxxxx> wrote:
> > @@ -349,6 +360,13 @@ EXPORT_SYMBOL_GPL(platform_device_unregi
> > * memory allocated for the device allows drivers using such devices
> > * to be unloaded iwithout waiting for the last reference to the device
> > * to be dropped.
> > + *
> > + * This interface is primarily intended for use with legacy drivers
> > + * which probe hardware directly. Because such drivers create device
> > + * nodes themselves, rather than letting system infrastructure handle
> > + * such device enumeration tasks, they don't fully conform to the Linux
> > + * driver model. In particular, when such drivers are built as modules,
> > + * they can't be "hotplugged".
> > */
> > struct platform_device *platform_device_register_simple(char *name, unsigned int id,
>
> I find this comment misleading. Many of these drivers do not create
> any devices (as in /dev/xxx) but rather create underlying hardware
> abstraction objects.

When I refresh this patch, I'll make it say "create sysfs device nodes" to
make clear which type of device node (not the /dev/ kind) it's referring to.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/