Re: [PATCH] Cleanup: i386 separate hardware-defined TSS from Linuxadditions

From: Rusty Russell
Date: Fri Mar 30 2007 - 01:45:36 EST


On Thu, 2007-03-29 at 21:33 -0500, Matt Mackall wrote:
> > unsigned short gs, __gsh;
> > unsigned short ldt, __ldth;
> > unsigned short trace, io_bitmap_base;
> > +} __attribute__((packed));
> > +
> > +struct tss_struct {
> > + struct i386_hw_tss x86_tss;
> > +
> > /*
> > * The extra 1 is there because the CPU will access an
> > * additional byte beyond the end of the IO permission
>
> This comment needs to stay in the first struct..?

Hi Matt!

Actually, it refers to the next field. To give complete context:

/*
* The extra 1 is there because the CPU will access an
* additional byte beyond the end of the IO permission
* bitmap. The extra byte must be all 1 bits, and must
* be within the limit.
*/
unsigned long io_bitmap[IO_BITMAP_LONGS + 1];

Cheers,
Rusty.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/