Re: 2.6.21-rc5-mm2 - compile error on x86-64

[Eric W. Biederman]

Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:
>
> Ah.  I assume you have CONFIG_SYSCTL=y, CONFIG_PROC_SYSCTL=n?
>
>
>
>
> From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>
> We're using #ifdef CONFIG_SYSCTL, but we should be using CONFIG_PROC_SYSCTL,
> so we get

I have no problem with the patch it is clearly more correct than what we
are doing now but I didn't think it was possible to select
CONFIG_SYSCTL and CONFIG_PROCFS without CONFIG_PROC_SYSCTL being
selected...
Do we have a constraint problem in Kconfig?  Or am I misremembering things?

>  fs/built-in.o: In function `proc_root_init':
>  /usr/src/linux/fs/proc/root.c:83: undefined reference to `proc_sys_init'
>
> Fix that up and remove an ifdef-in-C.
>
> Cc: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> Cc: Helge Hafting <helgehaf@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/