Re: [PATCH] fix dependency generation

From: Randy Dunlap
Date: Thu Mar 29 2007 - 12:37:39 EST


On Thu, 29 Mar 2007 17:06:24 +0100 Jan Beulich wrote:

> >>> Randy Dunlap <randy.dunlap@xxxxxxxxxx> 29.03.07 17:39 >>>
> >> --- linux-2.6.21-rc5/scripts/basic/fixdep.c 2007-02-04 19:44:54.000000000 +0100
> >> +++ 2.6.21-rc5-fixdep-mod/scripts/basic/fixdep.c 2007-03-29 11:11:10.000000000 +0200
> >> @@ -29,8 +29,7 @@
> >> * option which is mentioned in any of the listed prequisites.
> >> *
> >> * To be exact, split-include populates a tree in include/config/,
> >> - * e.g. include/config/his/driver.h, which contains the #define/#undef
> >> - * for the CONFIG_HIS_DRIVER option.
> >
> >I don't see why you deleted the line above.
>
> Because it is no longer true. These files are empty as of 2.6.18.

We seem to be talking about different lines above. Yes, the files
are empty, but they are named based on the CONFIG_symbol name, which
is what I was trying to get at. So how about a comment like this:

* To be exact, split-include populates a tree in include/config/,
* e.g., include/config/sysctl/syscall.h,
* for the CONFIG_SYSCTL_SYSCALL option, when that option
* is enabled (=y or =m).


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/