Re: [KJ][PATCH] BIT macro cleanup

From: Alexey Dobriyan
Date: Wed Mar 28 2007 - 15:11:00 EST


On Wed, Mar 28, 2007 at 09:03:09AM +0530, Milind Arun Choudhary wrote:
> --- a/include/linux/bitops.h
> +++ b/include/linux/bitops.h
> @@ -8,6 +8,9 @@
> */
> #include <asm/bitops.h>
>
> +#define BIT(nr) (1UL << ((nr) % BITS_PER_LONG))

I think this would be a disaster because something like

BIT(123)

would not even generate a warning.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/