Re: [patch] cache pipe buf page address for non-highmem arch

[Zach Brown]

> +#define pipe_kmap_atomic(page, type)	pipe_kmap(page)
> +#define pipe_kunmap(page)		do { } while (0)
> +#define pipe_kunmap_atomic(page, type)	do { } while (0)

Please don't drop arguments in stubs.  It can let completely broken  
code compile, like:

	pipe_kunmap(SOME_COMPLETE_NONSENSE);

Static inlines with empty bodies are the gold standard.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/