Re: [patch] add file position info to proc

[Miklos Szeredi]

> > Hi!
> > 
> > > From: Miklos Szeredi <mszeredi@xxxxxxx>
> > > 
> > > This patch adds support for finding out the current file position,
> > > open flags and possibly other info in the future.
> > > 
> > > These new entries are added:
> > > 
> > >   /proc/PID/fdinfo/FD
> > >   /proc/PID/task/TID/fdinfo/FD
> > > 
> > > For each fd the information is provided in the following format:
> > > 
> > > pos:	1234
> > > flags:	0100002
> > 
> > Octal? Maybe we should use more traditional hex here?

It's octal in <fcntl.h>, so it's easier for a human to read.

> Good point.  The O_foo flags are per-arch, so this field has the potential
> to be subtly different on different architectures, which is unpleasing.
> 
> > Or even list flags by name?
> 
> urg.  Simple enough to do (lookup table, please).  But is it worth it? 
> Perhaps just remove that field?

I wouldn't mind.  But leaving it to an application or for a human to
sort out is OK I guess.  There are lots of non-portable numbers in
proc.

Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/