Re: [patch] add file position info to proc

From: JÃrn Engel
Date: Tue Mar 27 2007 - 17:37:55 EST


On Tue, 27 March 2007 21:24:20 +0000, Pavel Machek wrote:
> > From: Miklos Szeredi <mszeredi@xxxxxxx>
> >
> > This patch adds support for finding out the current file position,
> > open flags and possibly other info in the future.
> >
> > These new entries are added:
> >
> > /proc/PID/fdinfo/FD
> > /proc/PID/task/TID/fdinfo/FD
> >
> > For each fd the information is provided in the following format:
> >
> > pos: 1234
> > flags: 0100002
>
> Octal? Maybe we should use more traditional hex here? Or even list
> flags by name?

The flags are defined in octal. Whether that choice makes sense or
should be rethought is a different question. I would definitely prefer
hex.

JÃrn

--
You ain't got no problem, Jules. I'm on the motherfucker. Go back in
there, chill them niggers out and wait for the Wolf, who should be
coming directly.
-- Marsellus Wallace
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/