Re: [PATCH -mm] Blackfin: spi driver cleanup and coding style fixing

[David Brownell]

On Monday 26 March 2007 3:14 am, Wu, Bryan wrote:
> Hi folks,
> 
> This patch cleanup blackfin SPI driver code and fix some coding style
> problems.

Good, thanks.  I'll forward the current state of my review, after
I cross-check it against these two patches.

That'll mean I need to re-start that review ... at that point it'd
be better to start with a single clean patch.


> -#ifdef DEBUG
> -#define ASSERT(expr) \
> -	if (!(expr)) { \
> -		printk(KERN_DEBUG "assertion failed! %s[%d]: %s\n", \
> -		       __FUNCTION__, __LINE__, #expr); \
> -		panic(KERN_DEBUG "%s", __FUNCTION__); \
> -	}
> -#else
> -#define ASSERT(expr)
> -#endif

Yes, that was certainly in the "remove that" category.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/