Re: [patch 2.6.21-rc5] arch/x86_64/kernel/early-quirks.c compilerwarning

[Andrew Morton]

On Mon, 26 Mar 2007 09:17:44 -0700
David Brownell <david-b@xxxxxxxxxxx> wrote:

> Fix "unused variable" compiler warning on non-SMP x86_64 configs.
> 
> Signed-off-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
> 
> --- a/arch/x86_64/kernel/early-quirks.c
> +++ b/arch/x86_64/kernel/early-quirks.c
> @@ -73,9 +73,9 @@ static void __init ati_bugs(void)
>  
>  static void intel_bugs(void)
>  {
> +#ifdef CONFIG_SMP
>  	u16 device = read_pci_config_16(0, 0, 0, PCI_DEVICE_ID);
>  
> -#ifdef CONFIG_SMP
>  	if (device == PCI_DEVICE_ID_INTEL_E7320_MCH ||
>  	    device == PCI_DEVICE_ID_INTEL_E7520_MCH ||
>  	    device == PCI_DEVICE_ID_INTEL_E7525_MCH)

This whole function gets removed by
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt-current/patches/revert-x86_64-mm-fix-the-irqbalance-quirk-for-e7320-e7520-e7525
so I think I'll duck the patch.  Which is very bad of me, because it means
2.6.21 goes out with this warning.  But I don't think many people build
non-SMP x86_64.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/