Re: Fix sudden warps in mousedev

From: Dmitry Torokhov
Date: Mon Mar 26 2007 - 15:31:00 EST


On 3/26/07, Pete Zaitcev <zaitcev@xxxxxxxxxx> wrote:
On Sun, 25 Mar 2007 23:19:38 -0400, Dmitry Torokhov <dtor@xxxxxxxxxxxxx> wrote:

> I tried to reproduce warping on console but could not for some reason. Could you
> please try the patch below and tell me if it fixes the problem for you?

> +++ work/drivers/input/mousedev.c
> @@ -124,32 +124,33 @@ static void mousedev_touchpad_event(stru
> - if (mousedev->pkt_count >= 2) {
> + if (mousedev->touch && mousedev->pkt_count >= 2) {

This works, thanks a lot.


Great! Then I'll queue it for 2.6.22.

The double-indented switch() is annoying, but since the whole driver
is written to the same style, I can live with it, for the uniformity
purposes :-)


Yes, the whole input is like this so I keep it consistent.

Regarding the synaptics driver and scroll problem. Yesterday I
scrolled twice through entire Remarque's "Spark of Life" off lib.ru
(once with 0.14.2 and once with latest git pull) and did not see any
scrollbar getting "stuck". Could it be newer xorg problem instead of
individual driver problem? I am using whatever xorg was installed in
FC3 which is somewhat dated... Also, could it be that the scroll issue
happens only in a certain application?

--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/