Re: [patch] ntp: avoid integer overflow in do_adjtimex()

From: Thomas Gleixner
Date: Sun Mar 25 2007 - 08:54:03 EST


On Sun, 2007-03-25 at 13:14 +0200, Ingo Molnar wrote:
> * Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> > Here you go. It's ugly, but it should do the trick for now.
> >
> > tglx
>
> here's your patch with proper metadata:
>
> --------------------->
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Subject: [patch] ntp: avoid integer overflow in do_adjtimex()
>
> John Stultz traced back ntpd problems to the following issue:
> do_adjtimex() [used by ntpd] can overflow if there's a too long delay
> between timer interrupts - as it can happen on NO_HZ. Expand the
> time_adjust calculation/division from 32 bits to 64 bits.

Wrong metadata. This is a patch to fix John's patch vs. signedness.

tglx



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/