Re: [PATCH] i386: Prevent early access to TSC to avoid crash on TSCless systems

[Ingo Molnar]

* Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> commit f9690982b8c2f9a2c65acdc113e758ec356676a3 removed the check for 
> cpu_khz from sched_clock(), which prevented early access to the TSC by 
> non obvious magic.
> 
> This is harmless as long as the CPU has a TSC. On TSCless systems this 
> results in an illegal instruction trap.
> 
> Replace tsc_disabled and tsc_unstable by tsc_enabled, which is only 
> set when the tsc is available and not unstable.
> 
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

oops, indeed! I think this should also resolve one of the bugs (TSC-less 
Cyrix?) that were reported against -mm some time ago.

Acked-by: Ingo Molnar <mingo@xxxxxxx>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/