Re: mm snapshot broken-out-2007-03-24-00-14.tar.gz uploaded

[David Miller]

From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Date: Sat, 24 Mar 2007 10:16:53 -0800

> On Sat, 24 Mar 2007 18:18:42 +0100 "Michal Piotrowski" <michal.k.k.piotrowski@xxxxxxxxx> wrote:
> 
> > On 24/03/07, akpm@xxxxxxxxxxxxxxxxxxxx <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > The mm snapshot broken-out-2007-03-24-00-14.tar.gz has been uploaded to
> > >
> > >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-03-24-00-14.tar.gz
> > >
> > 
> > My network doesn't work
> > "RTNETLINK answers: Invalid argument"
> > 
> > git-net* patches?
> > 
> 
> There's a huge collision between git-net and git-wireless which I haven't
> started to look at yet.  I suggest you forget about that particular
> snapshot.

We fixed that bug about a day after you likely took a snapshot
of the net-2.6.22 tree.

Here is the fix:

commit 65f96c1f4b549a3c3c19cebf9f0795c0d8fb35f0
Author: Thomas Graf <tgraf@xxxxxxx>
Date:   Thu Mar 22 21:41:06 2007 -0700

    [RTNL]: Properly return rntl message handler
    
    Signed-off-by: Thomas Graf <tgraf@xxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 35ce9f7..3a295e3 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -122,10 +122,10 @@ static rtnl_doit_func rtnl_get_doit(int protocol, int msgindex)
 	struct rtnl_link *tab;
 
 	tab = rtnl_msg_handlers[protocol];
-	if (tab == NULL || tab->doit == NULL)
+	if (tab == NULL || tab[msgindex].doit == NULL)
 		tab = rtnl_msg_handlers[PF_UNSPEC];
 
-	return tab ? tab->doit : NULL;
+	return tab ? tab[msgindex].doit : NULL;
 }
 
 static rtnl_dumpit_func rtnl_get_dumpit(int protocol, int msgindex)
@@ -133,10 +133,10 @@ static rtnl_dumpit_func rtnl_get_dumpit(int protocol, int msgindex)
 	struct rtnl_link *tab;
 
 	tab = rtnl_msg_handlers[protocol];
-	if (tab == NULL || tab->dumpit == NULL)
+	if (tab == NULL || tab[msgindex].dumpit == NULL)
 		tab = rtnl_msg_handlers[PF_UNSPEC];
 
-	return tab ? tab->dumpit : NULL;
+	return tab ? tab[msgindex].dumpit : NULL;
 }
 
 /**
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/