Re: HPA patches

From: Alan Cox
Date: Fri Mar 23 2007 - 16:44:06 EST


> > > What is 0x40? can it be #defined (or enum-ed) instead of a magic
> > > value? please? (more of same below)
> >
> > It's 0x40. Its a "command dependant bit" - no useful name.
>
> dependent. OK, thanks.

IDE is a bit like that. I'm amazed some of the command flags arent in
latin.

> Already corrected (printk types). And putting
> hpa_sectors);
> on a separate line doesn't hurt readability.

Maybe

Thanks for looking over the diff.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/