[patch 1/7] Add IRQF_IRQPOLL_IRQ flag (common code)

From: Bernhard Walle
Date: Fri Mar 23 2007 - 15:02:28 EST


This patch adds a IRQF_IRQPOLL_IRQ flag that the interrupt registration code
could use for the interrupt it wants to use for IRQ polling.

Because this must not be the timer interrupt, an additional flag was added
instead of re-using the IRQF_TIMER constant. Until all architectures will have
an IRQF_IRQPOLL_IRQ interrupt, irq == 0 will stay as alternative as it should
not break anything.

Also, note_interrupt() is called on CPU-specific interrupts to be used as
interrupt source for IRQ polling.


Signed-off-by: Bernhard Walle <bwalle@xxxxxxx>
---
include/linux/interrupt.h | 4 ++++
kernel/irq/handle.c | 2 ++
kernel/irq/spurious.c | 4 +++-
3 files changed, 9 insertions(+), 1 deletion(-)

Index: linux-2.6.21-rc4-mm1/include/linux/interrupt.h
===================================================================
--- linux-2.6.21-rc4-mm1.orig/include/linux/interrupt.h
+++ linux-2.6.21-rc4-mm1/include/linux/interrupt.h
@@ -44,6 +44,9 @@
* IRQF_TIMER - Flag to mark this interrupt as timer interrupt
* IRQF_PERCPU - Interrupt is per cpu
* IRQF_NOBALANCING - Flag to exclude this interrupt from irq balancing
+ * IRQF_IRQPOLL_IRQ - Interrupt is used for polling (only the interrupt that is
+ * registered first in an shared interrupt is considered for
+ * performance reasons)
*/
#define IRQF_DISABLED 0x00000020
#define IRQF_SAMPLE_RANDOM 0x00000040
@@ -52,6 +55,7 @@
#define IRQF_TIMER 0x00000200
#define IRQF_PERCPU 0x00000400
#define IRQF_NOBALANCING 0x00000800
+#define IRQF_IRQPOLL_IRQ 0x00001000

/*
* Migration helpers. Scheduled for removal in 1/2007
Index: linux-2.6.21-rc4-mm1/kernel/irq/handle.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/kernel/irq/handle.c
+++ linux-2.6.21-rc4-mm1/kernel/irq/handle.c
@@ -180,6 +180,8 @@ fastcall unsigned int __do_IRQ(unsigned
if (desc->chip->ack)
desc->chip->ack(irq);
action_ret = handle_IRQ_event(irq, desc->action);
+ if (!noirqdebug)
+ note_interrupt(irq, desc, action_ret);
desc->chip->end(irq);
return 1;
}
Index: linux-2.6.21-rc4-mm1/kernel/irq/spurious.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/kernel/irq/spurious.c
+++ linux-2.6.21-rc4-mm1/kernel/irq/spurious.c
@@ -146,7 +146,9 @@ void note_interrupt(unsigned int irq, st

if (unlikely(irqfixup)) {
/* Don't punish working computers */
- if ((irqfixup == 2 && irq == 0) || action_ret == IRQ_NONE) {
+ if ((irqfixup == 2 && ((irq == 0) ||
+ (desc->action->flags & IRQF_IRQPOLL_IRQ))) ||
+ action_ret == IRQ_NONE) {
int ok = misrouted_irq(irq);
if (action_ret == IRQ_NONE)
desc->irqs_unhandled -= ok;

--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/