Re: [v4l-dvb-maintainer] [PATCH] DVB: Delete unused header filelinux/dvb/version.h.

[Arjan van de Ven]

On Fri, 2007-03-23 at 16:47 +0100, Marcel Siegert wrote:
> On Friday 23 March 2007, Robert P. J. Day wrote:
> > 
> > Delete the unreferenced header file include/linux/dvb/version.h.
> > 
> > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> > 
> NACK
> this header is unreferenced in kernel, but used for applications that compile for userspace
> to determine the api version.


btw that is something extremely evil to do. Either you have varying apis
between kernels (which is naughty, but I suppose you can go up in
capabilities) or it's fully static. 

If it's dynamic, doing it compiletime is BAD. The same binaries should
run on multiple kernels after all. An ioctl or a sysfs thing or
something is a lot better than a compile time constant.

If it's entirely static exposing a "version" doesn't mean anything and
it might as well be killed...

Greetings,
   Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/