Re: [patch] cache pipe buf page address for non-highmem arch

From: Andrew Morton
Date: Thu Mar 22 2007 - 21:01:44 EST


On Thu, 22 Mar 2007 17:51:11 -0700 "Ken Chen" <kenchen@xxxxxxxxxx> wrote:

> +#ifdef CONFIG_HIGHMEM
> +#define pipe_kmap kmap
> +#define pipe_kmap_atomic kmap_atomic
> +#else /* CONFIG_HIGHMEM */
> +static inline void *pipe_kmap(struct page *page)
> +{
> + return (void *) page->private;
> +}
> +static inline void *pipe_kmap_atomic(struct page *page, enum km_type type)
> +{
> + pagefault_disable();
> + return pipe_kmap(page);
> +}
> +#endif

If we're going to do this then we should also implement pipe_kunmap_atomic().
Relying upon kunmap_atomic() internals like this is weird-looking, and is fragile
against future changes to kunmap_atomic().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/