Re: [PATCH] Sanitize filesystem NLS handling

[Alexander E. Patrakov]

Roman Zippel wrote:

> I agree that these parameters should be changable not just at compile time 
> and the iocharset should be a global default, but the on disk encoding is 
> often filesystem specific, so I'd rather keep this option per filesystem.

You are right, the on-disk encoding is filesystem specific. E.g., it is 
always UCS-2 for CIFS, NTFS and VFAT (and my patch doesn't change this).

It is exposed as a mount parameter and kernel configuration option only for 
fat and smbfs (the two filesystems that my patch touches for this matter), 
and both of these filesystems come from DOS days, where there was one 
codepage for a given country. So, for me, it made sense to glue these two 
parameters, because they both should be set to this codepage. The contrary 
would (AFAIK) only make sense if one gets floppies from France, but 
communicates with Polish SMB servers. It is a very rare situation, isn't it? 
Or do you know any other example where it would clearly make sense to have 
different defaults for fat and smbfs?

--
Alexander E. Patrakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/