Re: RSDL v0.31

From: Mike Galbraith
Date: Thu Mar 22 2007 - 05:34:50 EST


On Thu, 2007-03-22 at 10:18 +0100, Ingo Molnar wrote:
> * Mike Galbraith <efault@xxxxxx> wrote:
>
> > Actually, the numbers are an interesting curiosity point, but not as
> > interesting as the fact that the deadline mechanism isn't kicking in.
>
> it's not just the scheduling accounting being off, RSDL also seems to be
> accessing stale data here:
>
> > >From pull_task():
> > /*
> > * If this task has already been running on src_rq this priority
> > * cycle, make the new runqueue think it has been on its cycle
> > */
> > if (p->rotation == src_rq->prio_rotation)
> > p->rotation = this_rq->prio_rotation;
> >
> > The intent here is clearly that this task continue on the new cpu as
> > if nothing has happened. However, when the task was dequeued,
> > p->array was left as it was, points to the last place it was queued.
> > Stale data.
>
> it might point to a hot-unplugged CPU's runqueue as well. Which might
> work accidentally, but we want this fixed nevertheless.

Erk! I mentioned to Con offline that I've seen RSDL bring up only one
of my two (halves of a) penguins a couple three times out of a zillion
boots. Maybe that's why?

-Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/