Re: Problem with fix-rmmod-read-write-races-in-proc-entries.patch in 2.6.21-rc4-mm1

From: Al Viro
Date: Thu Mar 22 2007 - 04:29:16 EST


On Thu, Mar 22, 2007 at 09:14:45AM +0100, Eric Dumazet wrote:
> Also, do we really need to proxy via proc_reg_file_ops files that are not provided by a module ?
>
> I think not.
>
> Could you please add in proc_get_inode() a check against de->proc_fops->owner ?

Let's _not_. Bugs that depend on whether driver is built modular are
hell to deal with.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/