Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

[Mike Frysinger]

On 3/21/07, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> > +     p_adap->class = I2C_CLASS_ALL;
>
> This pretty much voids the point of these probing classes. You should
> only select the classes matching devices which may actually be probed
> for on this bus. If different boards have different needs, get the
> right classes from the platform data.

i asked about the class issue previously specifically for this bus
driver and was told that they werent really fully defined ... the
on-chip I2C interface on the Blackfin chip can handle any I2C device
which is why i added this line

any examples of how to go about doing it via boards ?  i dont see any
other I2C bus driver doing it that way ...
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/