Re: [PATCH] sysctl: vfs_cache_divisor

[Andrew Morton]

On Wed, 21 Mar 2007 16:01:32 -0700
Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:

> On Mon, 19 Mar 2007 21:22:33 -0700 H. Peter Anvin wrote:
> 
> > Randy Dunlap wrote:
> > >>
> > >> The we duplicate all the relevant /proc knobs:
> > >>
> > >> cat /proc/sys/vm/dirty_ratio
> > >> 30
> > >> cat /proc/sys/vm/hires-dirty_ratio/
> > >> 300000
> > >>
> > >> Or we do something else ;)
> > > 
> > > Sounds better.  I wasn't very keen on the userspace interface that this
> > > exposed.  Will look at those.
> > > 
> > 
> > Okay... may be I could throw a spanner in the machinery, and suggest 
> > another option: perhaps we should add a way to do sysctl which can 
> > handle fractional (fixed-point) values... more coherent/detailed message 
> > tomorrow.
> 
> I prefer the fixed-point values for pressure and dirty* to having
> duplicated entries for each of them.  I'll proceed with that idea.
> 

Problem is, if a read of /proc/sys/vm/dirty_ratio is changed to return
7.457 then existing userspace might get confused.

This might be acceptable if we are careful to ensure that reads of
/proc/sys/vm/dirty_ratio will always return an integer if it was previously
initialised with an integer.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/