Re: [PATCH 2.6.21-rc4] ieee1394: fix oops on "modprobe -r ohci1394"after network class_device conversion

[Stefan Richter]

On 20 Mar, Greg KH wrote:
> On Tue, Mar 20, 2007 at 10:43:22PM +0100, Stefan Richter wrote:
>> @@ -586,7 +586,10 @@ static void ether1394_add_host (struct h
>>          }
>>  
>>  	SET_MODULE_OWNER(dev);
>> +#if 0
>> +	/* FIXME - Is this the correct parent device anyway? */
>>  	SET_NETDEV_DEV(dev, &host->device);
>> +#endif
> 
> That's interesting.  What does 'tree /sys/class/net/' look like with
> this patch applied?  Does the eth1394 device now live off in
> /sys/device/virtual?

Yes.

lrwxrwxrwx  1 root root 0 Mär 21 01:02 eth0 -> ../../devices/pci0000:00/0000:00:0b.0/eth0/
lrwxrwxrwx  1 root root 0 Mär 21 01:02 eth1 -> ../../devices/virtual/net/eth1/
lrwxrwxrwx  1 root root 0 Mär 21 01:02 lo -> ../../devices/virtual/net/lo/

(eth1 is IP over 1394 alias eth1394. eth0 is an actual ethernet
interface.)

And eth1/device (ex -> ../../../devices/pci*___*/fw-host*) is now gone.
Would anybody miss it?

> If so, I guess this is ok for now as we can wait for the rewrite of the
> ieee1394 subsystem to get the linking done correctly :)

That's my hope too.
-- 
Stefan Richter
-=====-=-=== --== =-=-=
http://arcgraph.de/sr/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/