Re: mm snapshot broken-out-2007-03-18-02-44.tar.gz uploaded

[Nick Piggin]

Andrew Morton wrote:
> On Tue, 20 Mar 2007 13:47:53 +1100 Nick Piggin <nickpiggin@xxxxxxxxxxxx> wrote:
>
>
> > Andrew Morton wrote:

> > Hang on a sec... I'll try fixing the thing before you next make a
> > release.
>
>
> Too late.  hot-fixes/ awaits thee.

Awww... well thanks very much Michal for reporting the bug, I reproduced
it easily and it turns out to be a typo.

In my testing I never had a lot of writeout going on, so most of the pages
will have been truncated in the first loop...

--
SUSE Labs, Novell Inc.
Fix typo in do_no_page vs invalidate race fix patch.

Index: linux-2.6/mm/truncate.c
===================================================================
--- linux-2.6.orig/mm/truncate.c
+++ linux-2.6/mm/truncate.c
@@ -235,7 +235,7 @@ void truncate_inode_pages_range(struct a
 			wait_on_page_writeback(page);
 			if (page_mapped(page)) {
 				unmap_mapping_range(mapping,
-				  (loff_t)page_index<<PAGE_CACHE_SHIFT,
+				  (loff_t)page->index<<PAGE_CACHE_SHIFT,
 				  PAGE_CACHE_SIZE, 0);
 			}
 			if (page->index > next)