Re: sysfs_drop_dentry(): possible NULL dereference

[Oliver Neukum]

Am Montag, 19. MÃrz 2007 10:22 schrieb Adrian Bunk:

>  void sysfs_drop_dentry(struct sysfs_dirent * sd, struct dentry * parent)
>  {
>         struct dentry * dentry = sd->s_dentry;
> +       struct inode *inode;
>  
>         if (dentry) {
>                 spin_lock(&dcache_lock);
>                 spin_lock(&dentry->d_lock);
>                 if (!(d_unhashed(dentry) && dentry->d_inode)) {
> +                       inode = dentry->d_inode;
> +                       spin_lock(&inode->i_lock);
> ...
> 
> <--  snip  -->
> 
> If (!dentry->d_inode), then it's a NULL dereference.

As far as I can tell, sysfs being a virtual filesystem, does not use
dentries without inodes associated.

	Regards
		Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/