Re: [PATCH] hrtimer: prevent overrun DoS in hrtimer_forward()

From: Chuck Ebbert
Date: Sun Mar 18 2007 - 17:20:56 EST


Thomas Gleixner wrote:
>
> I'd prefer this one: The maximum seconds value we can handle on 32bit is
> LONG_MAX.
>
> diff --git a/include/linux/ktime.h b/include/linux/ktime.h
> index c68c7ac..248305b 100644
> --- a/include/linux/ktime.h
> +++ b/include/linux/ktime.h
> @@ -57,7 +57,11 @@ typedef union {
> } ktime_t;
>
> #define KTIME_MAX ((s64)~((u64)1 << 63))
> -#define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC)
> +#if (BITS_PER_LONG == 64)
> +# define KTIME_SEC_MAX (KTIME_MAX / NSEC_PER_SEC)
> +#else
> +# define KTIME_SEC_MAX LONG_MAX
> +#endif
>
> /*
> * ktime_t definitions when using the 64-bit scalar representation:
>

Just to be clear: this replaces the earlier patch, right?




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/