Re: dst_ifdown breaks infiniband?

From: Michael S. Tsirkin
Date: Sun Mar 18 2007 - 16:28:46 EST


> > > It should be cleared and we should be sure it will not be destroyed
> > > before quiescent state.
> >
> > I'm confused. didn't you say dst_ifdown is called after quiescent state?
>
> Quiescent state should happen after dst->neighbour is invalidated.
> And this implies that all the users of dst->neighbour check validity
> after dereference and do not use it after quiescent state.
>
>
> > This does not sound like something that's likely to be accepted in 2.6.21, right?
> >
> > Any simpler ideas?
>
> Well, if inifiniband destructor really needs to take that lock... no.
> Right now I do not see.

OK then.
If you post some patches I'll test them.

--
MST
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/