Re: [git patches] IDE fixes

From: Linus Torvalds
Date: Sat Mar 17 2007 - 20:05:22 EST




On Sat, 17 Mar 2007, Bartlomiej Zolnierkiewicz wrote:
>
> to receive the following updates:
>
> b/drivers/ide/Kconfig | 48 -
> b/drivers/ide/Makefile | 1
> b/drivers/ide/arm/icside.c | 13
> b/drivers/ide/ide-dma.c | 2
> b/drivers/ide/ide.c | 4
> b/drivers/ide/mips/au1xxx-ide.c | 3
> b/drivers/ide/pci/Makefile | 1
> b/drivers/ide/pci/cmd64x.c | 45 -
> b/drivers/ide/pci/jmicron.c | 29
> b/drivers/ide/pci/scc_pata.c | 858 ++++++++++++++++++++++++++++
> b/drivers/ide/setup-pci.c | 5
> b/include/asm-mips/mach-au1x00/au1xxx_ide.h | 34 -
> drivers/ide/ppc/scc_pata.c | 858 ----------------------------
> 13 files changed, 915 insertions(+), 986 deletions(-)

Please use

git diff -M --stat --summary

to generate the diffstat (where the "-M" is the important part). Your
"scc_pata.c" change was a pure rename, but because you didn't ask for
rename detection, it got shown as a file create/delete pair. It *should*
have looked like this:

drivers/ide/Kconfig | 48 +++++------------------------
drivers/ide/Makefile | 1 -
drivers/ide/arm/icside.c | 13 +-------
drivers/ide/ide-dma.c | 2 +-
drivers/ide/ide.c | 4 --
drivers/ide/mips/au1xxx-ide.c | 3 +-
drivers/ide/pci/Makefile | 1 +
drivers/ide/pci/cmd64x.c | 45 ++++++++++++---------------
drivers/ide/pci/jmicron.c | 29 ++++++++++++++---
drivers/ide/{ppc => pci}/scc_pata.c | 0
drivers/ide/setup-pci.c | 5 ---
include/asm-mips/mach-au1x00/au1xxx_ide.h | 34 --------------------
12 files changed, 57 insertions(+), 128 deletions(-)
rename drivers/ide/{ppc => pci}/scc_pata.c (100%)

which is a lot more accurate than what you get by feeding a diff through
"diffstat" that has no clue about renames (look at the summary for number
of lines changed ;)

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/