[PATCH 2.6.21-rc4] kernel/exit: Fix a comment and code contradiction

From: Ahmed S. Darwish
Date: Sat Mar 17 2007 - 02:26:05 EST


Hi list,

Comment in release_task() claims that group leader's parent process
is signalled only if it desires so, which is not true.

Signed-off-by: Ahmed S. Darwish <darwish.07@xxxxxxxxx>
---

To save your time, here's the contradictory code which don't appear in
the patch (appears after its last line):

leader = p->group_leader;
if (leader != p && thread_group_empty(leader) && leader->exit_state == EXIT_ZOMBIE) {
BUG_ON(leader->exit_signal == -1);
do_notify_parent(leader, leader->exit_signal);


diff --git a/kernel/exit.c b/kernel/exit.c
index f132349..4a0a35f 100644
--- a/kernel/exit.c
+++ b/kernel/exit.c
@@ -152,7 +152,7 @@ repeat:
/*
* If we are the last non-leader member of the thread
* group, and the leader is zombie, then notify the
- * group leader's parent process. (if it wants notification.)
+ * group leader's parent process.
*/
zap_leader = 0;
leader = p->group_leader;

--
Ahmed S. Darwish
http://darwish.07.googlepages.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/