Re: Kconfig style question

From: Sam Ravnborg
Date: Fri Mar 16 2007 - 16:09:15 EST


On Fri, Mar 16, 2007 at 08:53:53AM +0100, Bodo Eggert wrote:
> Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > For source lines I've seen both:
> >
> > source "arch/powerpc/platforms/52xx/Kconfig"
> >
> > and
> >
> > source arch/powerpc/platforms/85xx/Kconfig
> >
> > Is there a preferred style? Quotes or not?
>
> $ find . -name Kconfig -exec grep ^source '{}' \;|grep \"|wc -l
> 732
> $ find . -name Kconfig -exec grep ^source '{}' \;|grep -v \"|wc -l
> 44

Which is somewaht funny.
source is defined like this:
"source" <prompt>

Where <prompt> may be a single string without spaces or
a quoted string with spaces.
So kconfig allow you to use spaces in the path/filename. But
then most users uses "" despite it is not needed since we obviously
do not use spaces in path/filename in the kernel due to
make limitations (and good taste).

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/