Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable

From: Ingo Molnar
Date: Fri Mar 16 2007 - 05:34:56 EST



* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> This patch introduces paravirt_ops hooks to control how the kernel's
> initial pagetable is set up.

looks good. Some minor nits:

> + /* Make sure kernel address space is empty so that a pagetable
> + will be allocated for it. */

comment style.

> + /* Enable PSE if available */
> + if (cpu_has_pse) {
> + set_in_cr4(X86_CR4_PSE);
> + }

unnecessary braces.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/