Re: [PATCH] oom fix: prevent oom from killing a process with children/sibling unkillable

From: William Lee Irwin III
Date: Thu Mar 15 2007 - 18:23:13 EST


On Thu, Mar 15, 2007 at 07:19:21PM +0530, Ankita Garg wrote:
> Looking at oom_kill.c, found that the intention to not kill the selected
> process if any of its children/siblings has OOM_DISABLE set, is not being met.
> Signed-off-by: Ankita Garg <ankita@xxxxxxxxxx>
> Index: ankita/linux-2.6.20.1/mm/oom_kill.c
> ===================================================================
> --- ankita.orig/linux-2.6.20.1/mm/oom_kill.c 2007-02-20 12:04:32.000000000 +0530
> +++ ankita/linux-2.6.20.1/mm/oom_kill.c 2007-03-15 12:44:50.000000000 +0530
> @@ -320,7 +320,7 @@
> * Don't kill the process if any threads are set to OOM_DISABLE
> */
> do_each_thread(g, q) {
> - if (q->mm == mm && p->oomkilladj == OOM_DISABLE)
> + if (q->mm == mm && q->oomkilladj == OOM_DISABLE)
> return 1;
> } while_each_thread(g, q);

Acked-by: William Irwin <wli@xxxxxxxxxxxxxx>


-- wli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/