Re: [PATCH] Remove "decl_subsys_name" macro and single usage of it.

From: Greg KH
Date: Thu Mar 15 2007 - 03:38:16 EST


On Thu, Mar 01, 2007 at 12:09:59PM -0500, Robert P. J. Day wrote:
>
> Remove the macro "decl_subsys_name" which can be used to declare a
> sysfs subsystem, along with the single invocation of it in the source
> tree, since there appears to be little value in creating a subsystem
> whose subsystem name differs from its structure name. Everyone else
> just uses "decl_subsys".
>
> Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
>
> @@ -800,7 +800,7 @@ MODULE_LICENSE("GPL");
> module_param(debug, bool, 0644);
> MODULE_PARM_DESC(debug, "Debugging mode enabled or not");
>
> -EXPORT_SYMBOL_GPL(pci_hotplug_slots_subsys);
> +EXPORT_SYMBOL_GPL(slots_subsys);

No, don't polute the namespace incorrectly here. We really want the
variable to still have the "pci_hotplug_" prefix if at all possible.

thanks,

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/