Re: [PATCH 13/13] fix ps3fb glue allowing a modular build

From: Al Viro
Date: Wed Mar 14 2007 - 13:07:46 EST


On Wed, Mar 14, 2007 at 05:17:45PM +0100, Geert Uytterhoeven wrote:
> Hi Al,
>
> On Wed, 14 Mar 2007, Al Viro wrote:
> > On Wed, Mar 14, 2007 at 10:50:16AM +0100, Geert Uytterhoeven wrote:
> > > On Wed, 14 Mar 2007, Al Viro wrote:
> > > > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > >
> > > NAK
> >
> > Lovely... Consider that one withdrawn, please. FWIW, if we leave it bool
> > (and flip_ctl mess alone would make a good reason for that) we probably want
> > to have it depend on FB=y
>
> What's the advantage of making FB_PS3 depend on FB=y vs. plain FB?
> In both cases it can be enabled if FB=y only, right? Or am I missing something?

Nope. How can kconfig distinguish that from a boolean option in modular
driver? bool *can* depend on tristate and be selected when tristate is
set to m.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/