Re: [PATCH] usb-serial regression fix

From: Oliver Neukum
Date: Tue Mar 13 2007 - 09:50:53 EST


Am Dienstag, 13. März 2007 14:39 schrieb Mark Lord:
> Oliver Neukum wrote:
> >
> > If we get to destroy_serial(), how can ports still be open?
>
> (1) open up a ckermit session on /dev/usb_serial_port_0.
> (2) suspend the machine (to RAM).
> (3) the suspend logic "removes" all USB devices.

No,

any open port has taken a reference in serial_open():
serial = usb_serial_get_by_index(tty->index);

destroy_serial() can be called only when the refcount goes to zero. How
can there be open ports?

Regards
Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/