Re: [PATCH] x86_64, i386: Add command line length to boot protocol

From: Pavel Machek
Date: Mon Mar 12 2007 - 16:22:40 EST


On Tue 2007-03-06 13:21:34, Dave Jones wrote:
> On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote:
>
> > +cmdline_size: .long COMMAND_LINE_SIZE-1 #length of the command line,
>
> Why a long? It's unlikely that someone is going to have a command line
> bigger than 0xffff.

Well, I could imagine overflowing that. Describing your numa setup,
excluding few bad bits of ram using memmap=exact, set up your boot
over iscsi on cmdline.... these are likely to eat insane ammount of
cmdline space.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/