Re: [PATCH] MPT FUSION: Delete unused header files.

From: Valdis . Kletnieks
Date: Sun Mar 11 2007 - 18:33:03 EST


On Sun, 11 Mar 2007 13:55:54 MDT, Eric Moore said:
>
> With respect to mpi_log_fc.h - this defines the loginfo for fibre channel
> protocal. This is a easy lookup to for LSI Logic customers to better
> understand the kind of errors returned from firmware, and help reduce number
> of support generated request, as the end user can merely lookup the unqiue
> id in the header file.

Certainly appropriate content for something on your website, and vendors who
provide programs like dmidecode and parsemce are always welcome. I could
probably be convinced that such info should have at least a pointer somewhere
in Documentation/lsi_debug.txt or some such. But quite frankly, if I'm reduced
to wading through *.h files to figure out what some recalcitrant hardware is
upset about, there's been a failure in documentation. *ESPECIALLY* if I
go look at drivers/whatever/source.c and it doesn't even *reference* the *.h
file in question.

> mpi_inb.h, is header for fibre channel protocal
> ng the inband-management interface, and maybe implemented some day.

Feel free to include mpi_inb.h when you submit the interface for merging.

Attachment: pgp00000.pgp
Description: PGP signature