Re: [PATCH] Fix sparc TIF_USEDFPU flag atomicity

From: David Miller
Date: Sat Mar 10 2007 - 03:30:08 EST


From: William Lee Irwin III <wli@xxxxxxxxxxxxxx>
Date: Sat, 10 Mar 2007 00:26:46 -0800

> On Sat, Mar 10, 2007 at 03:17:43AM -0500, Mathieu Desnoyers wrote:
> > @@ -348,7 +348,7 @@ void exit_thread(void)
> > #ifndef CONFIG_SMP
> > if(last_task_used_math == current) {
> > #else
> > - if(current_thread_info()->flags & _TIF_USEDFPU) {
> > + if(test_ti_thread_flag(current_thread_info(), TIF_USEDFPU)) {
> > #endif
> > /* Keep process from leaving FPU in a bogon state. */
> > put_psr(get_psr() | PSR_EF);
>
> Oh dear. Could we bit a bit more idiomatic here? For instance,
> something like:

Ok I pulled the sparc32 patch back out until there is some
consensus here :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/