Re: [PATCH] x86_64 RESTORE_CONTEXT missing '\n'

From: Andi Kleen
Date: Thu Mar 08 2007 - 17:37:00 EST


On Thursday 08 March 2007 19:49, Tom Rini wrote:
> On Thu, Mar 08, 2007 at 07:37:56PM +0100, Andi Kleen wrote:
> > On Thursday 08 March 2007 18:44, Dave Jiang wrote:
> >
> > > In spite of kgdb, shouldn't it have that \n anyways in case some other code
> > > gets added in the future after the macro? Or are you saying that there should
> > > never be any code ever after that macro?
> >
> > Sure if there is mainline code added after that macro we add the \n.
> > But only if it makes sense to add code there, which it didn't in kgdb.
>
> Was that because with recent enough tools and config options there was
> enough annotations so GDB could finally figure out where things had
> stopped?

The x86 kernels are fully dwarf2 annotiated yes.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/