Re: PAGE_SIZE Availability Inconsistency

From: David Miller
Date: Thu Mar 08 2007 - 16:48:42 EST


From: Anton Blanchard <anton@xxxxxxxxx>
Date: Thu, 8 Mar 2007 15:42:36 -0600

> > The easiest way to fix this would be to always park the swap magic at
> > the offset of the smallest page size in use, which is 4K. This is
> > analogous how the offset for the ext2/3 superblock got fixed at 1K --
> > for 1K blocks, it's the second block, but for larger blocks, it's part
> > of the first block. If we fix the offset of the swap magic at 4096
> > minus the offset that's already there, it will always fall in the first
> > page regardless of page size.
>
> Yeah that makes sense. I gave it a go by creating a MIN_PAGE_SIZE
> define, and allowing an architecture to override it if required.

I might be missing something but doesn't this break every
SWAP partition that was created with something other than
MIN_PAGE_SIZE?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/