Re: [PATCH] Loop device - Tracking page writes made to a loop devicethrough mmap

From: Jari Ruusu
Date: Thu Mar 08 2007 - 14:12:06 EST


Kandan Venkataraman wrote:
> All comments have been taken care of.

Your patch still does not do conversions of existing user space visible
'struct loop_info64' which is pretty much cast in stone. Blindly overwriting
larger structure over smaller user space buffer of existing userspace
binaries is the wrong way to do this.

There was a time when folks at least pretended that breaking user space ABI
was not tolerable.

--
Jari Ruusu 1024R/3A220F51 5B 4B F9 BB D3 3F 52 E9 DB 1D EB E3 24 0E A9 DD
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/